Messages in this thread | | | Subject | Re: [PATCH] ocxl: fix signed comparison with less than zero | From | Andrew Donnellan <> | Date | Wed, 31 Jan 2018 10:42:47 +1100 |
| |
On 31/01/18 02:11, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Currently the comparison of used < 0 is always false because > uses is a size_t. Fix this by making used a ssize_t type. > > Detected by Coccinelle: > drivers/misc/ocxl/file.c:320:6-10: WARNING: Unsigned expression > compared with zero: used < 0 > > Fixes: 5ef3166e8a32 ("ocxl: Driver code for 'generic' opencapi devices") > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks for picking this up!
Acked-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> --- > drivers/misc/ocxl/file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c > index c90c1a578d2f..1287e4430e6b 100644 > --- a/drivers/misc/ocxl/file.c > +++ b/drivers/misc/ocxl/file.c > @@ -277,7 +277,7 @@ static ssize_t afu_read(struct file *file, char __user *buf, size_t count, > struct ocxl_context *ctx = file->private_data; > struct ocxl_kernel_event_header header; > ssize_t rc; > - size_t used = 0; > + ssize_t used = 0; > DEFINE_WAIT(event_wait); > > memset(&header, 0, sizeof(header)); >
-- Andrew Donnellan OzLabs, ADL Canberra andrew.donnellan@au1.ibm.com IBM Australia Limited
| |