lkml.org 
[lkml]   [2018]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/4] i2c: xlp9xx: return ENXIO on slave address NACK
From
Date
Gentle Ping on this series.

On 01/18/2018 11:09 AM, George Cherian wrote:
> From: Dmitry Bazhenov <dmitry.bazhenov@auriga.com>
>
> Fix the driver violation of the common practice to return
> ENXIO error on a slave address NACK.
>
> Signed-off-by: Dmitry Bazhenov <dmitry.bazhenov@auriga.com>
> Signed-off-by: George Cherian <george.cherian@cavium.com>
> ---
> drivers/i2c/busses/i2c-xlp9xx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-xlp9xx.c b/drivers/i2c/busses/i2c-xlp9xx.c
> index b970bf8..6d78cdc 100644
> --- a/drivers/i2c/busses/i2c-xlp9xx.c
> +++ b/drivers/i2c/busses/i2c-xlp9xx.c
> @@ -324,7 +324,8 @@ static int xlp9xx_i2c_xfer_msg(struct xlp9xx_i2c_dev *priv, struct i2c_msg *msg,
> dev_dbg(priv->dev, "transfer error %x!\n", priv->msg_err);
> if (priv->msg_err & XLP9XX_I2C_INTEN_BUSERR)
> xlp9xx_i2c_init(priv);
> - return -EIO;
> + return (priv->msg_err & XLP9XX_I2C_INTEN_NACKADDR) ?
> + -ENXIO : -EIO;
> }
>
> if (timeleft == 0) {
>

Regards
-George

\
 
 \ /
  Last update: 2018-01-30 15:29    [W:0.141 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site