lkml.org 
[lkml]   [2018]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] nvme: check ctrl.tagset before start ns scan
From
Date
Hi sagi

Many thanks for your kindly response.

On 01/03/2018 05:37 PM, Sagi Grimberg wrote:
> Hi Jianchao,
>
>> ctrl.tagset maybe NULL due to failure of io queue setup or blk-mq
>> tagset allocation in nvme_reset_work. Then panic would come up.
>> To fix this, just add ctrl.tagset check in nvme_scan_work.
>
> This came up before (and forgotten...) I think we should not
> have state indicators other than ctrl->state.
>
> How about instead we add a new state NVME_CTRL_ADMIN_LIVE when we have
> no I/O queues.
>
Yes, that's a good idea that add a new state NMVE_CTRL_ADMIN_LIVE to indicate
only the admin queue live. On the other hand, add a sanity checking that whether
ctrl->tagset is NULL is also necessary. :)

Thanks
Jianchao

\
 
 \ /
  Last update: 2018-01-04 05:03    [W:0.032 / U:4.428 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site