lkml.org 
[lkml]   [2018]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] dt-bindings: mtd: atmel-quadspi: add an optional property 'dmacap,memcpy'
On Tue, Jan 02, 2018 at 07:18:58PM +0000, Trent Piepho wrote:
> On Tue, 2018-01-02 at 11:22 +0100, Ludovic Desroches wrote:
> > On Wed, Dec 27, 2017 at 10:40:00PM +0100, Cyrille Pitchen wrote:
> >
> > > Or maybe no change at all is required at the at_xdmac.c driver side: we
> > > just don't care about the provided flags in the "dmas" property, especially
> > > the "peripheral id". They would be ignored anyway when the atmel-quadspi.c
> > > driver later calls dmaengine_prep_dma_memcpy(). So I could simply set the
> > > dma cells to 0 in the device-tree?
> > >
> > > Ludovic, what do you think about that ?
> >
> > It may work but I won't do this. Usually, channels requested through the xlate
> > function have usually their capaiblities set to DMA_SLAVE and not DMA_MEMCPY.
> > In the at_xdmac case, it won't be an issue but if you have a controller
> > which has channels which can support only mem-to-mem or peripheral, it
> > won't work.
>
> Maybe one could create an "AT91_XDMAC_DT_" macro to indicate a memcpy
> channel. There are still unused bits for another flag. It also looks
> like at_xdma uses peripheral id 0x3f for memcpy transfers (will that
> work with memcpy DMA on multiple channels at the same time?). So
> perhaps perid 0x3f could be the indication of wanting a memcpy channel,
> rather than another flag bit. But however it's done, one writes:
>
> dmas = <&dma0 AT91_XDMAC_DT_MEMCPY>; dma-names = "rx-tx";
>

If have no objection about doing that, my concerns are:
- most (all ?) of the dma controllers used the xlate function to provide
slave channel. Does it have to provide slave channel or can we
use it for all kind of channel? From my point of view, we can do it,
just need the confirmation.
- this set of patches if focused on the atmel qspi controller but other
ones may be interested in doing the same thing so they would have to
update the behavior of the xlate function of the DMA controller they
are using. So having the request of a DMA_MEMCPY channel inside the
spi/qspi controller doesn't seem to be a wrong idea. Moreover, it may
be confusing for the user who don't know the context: why do I have to
use memcpy and not slave as usal?

Honestly I have no opinion about the way to do it. Both have pros and
cons.

> I think one could have the quadspi driver automatically fill in the dma
> cell in the dma specifier if it is not present in the device tree. So
> one could write "dmas = <&dma0>" and the driver adds the
> AT91_XDMAC_DT_MEMCPY cell before xlating. I'm not sure if that's a
> good idea or not.

I don't think so, there is enough black magic, let's try to not add more
:p

Regards

Ludovic

\
 
 \ /
  Last update: 2018-01-03 07:53    [W:0.026 / U:2.904 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site