Messages in this thread | | | From | "Dilger, Andreas" <> | Subject | Re: [PATCH] staging: lustre: lnet: return of an error code should be negative | Date | Tue, 30 Jan 2018 01:49:17 +0000 |
| |
On Jan 27, 2018, at 22:24, Sumit Pundir <pundirsumit11@gmail.com> wrote: > > Return value of error codes should typically be negative. > Issue reported by checkpatch.pl > > Signed-off-by: Sumit Pundir <pundirsumit11@gmail.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
> --- > drivers/staging/lustre/lnet/selftest/framework.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lnet/selftest/framework.c b/drivers/staging/lustre/lnet/selftest/framework.c > index c7697f6..0ca1e3a 100644 > --- a/drivers/staging/lustre/lnet/selftest/framework.c > +++ b/drivers/staging/lustre/lnet/selftest/framework.c > @@ -187,7 +187,7 @@ sfw_del_session_timer(void) > return 0; > } > > - return EBUSY; /* racing with sfw_session_expired() */ > + return -EBUSY; /* racing with sfw_session_expired() */ > } > > static void > -- > 2.7.4 >
Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel Corporation
| |