lkml.org 
[lkml]   [2018]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 50/66] be2net: restore properly promisc mode after queues reconfiguration
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Ivan Vecera <cera@cera.cz>


    [ Upstream commit 52acf06451930eb4cefabd5ecea56e2d46c32f76 ]

    The commit 622190669403 ("be2net: Request RSS capability of Rx interface
    depending on number of Rx rings") modified be_update_queues() so the
    IFACE (HW representation of the netdevice) is destroyed and then
    re-created. This causes a regression because potential promiscuous mode
    is not restored properly during be_open() because the driver thinks
    that the HW has promiscuous mode already enabled.

    Note that Lancer is not affected by this bug because RX-filter flags are
    disabled during be_close() for this chipset.

    Cc: Sathya Perla <sathya.perla@broadcom.com>
    Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>
    Cc: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
    Cc: Somnath Kotur <somnath.kotur@broadcom.com>

    Fixes: 622190669403 ("be2net: Request RSS capability of Rx interface depending on number of Rx rings")
    Signed-off-by: Ivan Vecera <ivecera@redhat.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/emulex/benet/be_main.c | 9 +++++++++
    1 file changed, 9 insertions(+)

    --- a/drivers/net/ethernet/emulex/benet/be_main.c
    +++ b/drivers/net/ethernet/emulex/benet/be_main.c
    @@ -4733,6 +4733,15 @@ int be_update_queues(struct be_adapter *

    be_schedule_worker(adapter);

    + /*
    + * The IF was destroyed and re-created. We need to clear
    + * all promiscuous flags valid for the destroyed IF.
    + * Without this promisc mode is not restored during
    + * be_open() because the driver thinks that it is
    + * already enabled in HW.
    + */
    + adapter->if_flags &= ~BE_IF_FLAGS_ALL_PROMISCUOUS;
    +
    if (netif_running(netdev))
    status = be_open(netdev);


    \
     
     \ /
      Last update: 2018-01-29 22:13    [W:4.164 / U:0.404 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site