lkml.org 
[lkml]   [2018]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 36/66] ipv6: ip6_make_skb() needs to clear cork.base.dst
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Eric Dumazet <edumazet@google.com>


    [ Upstream commit 95ef498d977bf44ac094778fd448b98af158a3e6 ]

    In my last patch, I missed fact that cork.base.dst was not initialized
    in ip6_make_skb() :

    If ip6_setup_cork() returns an error, we might attempt a dst_release()
    on some random pointer.

    Fixes: 862c03ee1deb ("ipv6: fix possible mem leaks in ipv6_make_skb()")
    Signed-off-by: Eric Dumazet <edumazet@google.com>
    Reported-by: syzbot <syzkaller@googlegroups.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/ipv6/ip6_output.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/net/ipv6/ip6_output.c
    +++ b/net/ipv6/ip6_output.c
    @@ -1800,6 +1800,7 @@ struct sk_buff *ip6_make_skb(struct sock
    cork.base.flags = 0;
    cork.base.addr = 0;
    cork.base.opt = NULL;
    + cork.base.dst = NULL;
    v6_cork.opt = NULL;
    err = ip6_setup_cork(sk, &cork, &v6_cork, ipc6, rt, fl6);
    if (err) {

    \
     
     \ /
      Last update: 2018-01-29 21:33    [W:4.020 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site