Messages in this thread | | | Date | Mon, 29 Jan 2018 11:18:51 -0600 | From | Rob Herring <> | Subject | Re: [PATCH v3 11/16] mmc: tmio: deprecate "toshiba,mmc-wrprotect-disable" DT property |
| |
On Thu, Jan 18, 2018 at 10:58:36AM +0900, Masahiro Yamada wrote: > 2018-01-18 1:28 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>: > > This property is equivalent to "disable-wp" defined in > > Documentation/devicetree/bindings/mmc/tmio_mmc.txt > > This is mistake. > > "disable-wp" is defined in > > Documentation/devicetree/bindings/mmc/mmc.txt > > > > > > The TMIO MMC core calls mmc_of_parse(), and it sets > > MMC_CAP2_NO_WRITE_PROTECT if "disable-wp" property is present. > > > > We do not need a vendor-specific property to do the same thing. > > > > Let's remove the description from the dt-binding to prevent new boards > > from using it. > > > > I am keeping the driver code for existing DT files, but added > > comments that this is deprecated. > > > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > --- > > > > Changes in v3: > > - newly added > > > > Changes in v2: None > > > > Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 1 -
Other than the above,
Acked-by: Rob Herring <robh@kernel.org>
> > drivers/mmc/host/tmio_mmc_core.c | 5 +++++ > > 2 files changed, 5 insertions(+), 1 deletion(-)
| |