Messages in this thread | | | From | "Yang, Shunyong" <> | Subject | Re: Re: [PATCH 1/2] dmaengine: dmatest: change symbolic permissions to octal values | Date | Mon, 29 Jan 2018 06:26:40 +0000 |
| |
Hi, Vinod
On Mon, 2018-01-29 at 10:18 +0530, Vinod Koul wrote: > On Mon, Jan 22, 2018 at 06:44:40PM +0800, Yang Shunyong wrote: > > > > Current coding style prefers octal permissions values. This patch > > changes symbolic permissions to octal values. > Is this preference documented anywhere? >
When using symbolic permissions like "S_IRUGO | S_IWUSR". The checkpatch.pl will output some warnings to suggest to use octal values. I quote following lines from checkpatch.pl,
# check for uses of S_<PERMS> that could be octal for readability ... if (WARN("SYMBOLIC_PERMS", "Symbolic permissions '$oval' are not preferred. Consider using octal permissions '$octal'.\n" . $herecurr) && $fix) { $fixed[$fixlinenr] =~ s/$val/$octal/; }
Thanks. Shunyong
| |