Messages in this thread | | | Subject | Re: [Patch v7 12/12] Documention: v4l: Documentation for HEVC CIDs | From | Hans Verkuil <> | Date | Mon, 29 Jan 2018 14:39:38 +0100 |
| |
On 01/29/2018 02:15 PM, Smitha T Murthy wrote: >>>> >>> The values set in V4L2_CID_MPEG_VIDEO_HEVC_MIN_QP and >>> V4L2_CID_MPEG_VIDEO_HEVC_MAX_QP will give the limits for the L0-L6 QP >>> values that can be set. >> >> OK. If you can clarify this in the documentation, then I can Ack this. >> >> Note: if userspace changes MIN_QP or MAX_QP, then the driver should call >> v4l2_ctrl_modify_range() to update the ranges of the controls that are >> impacted by QP range changes. I'm not sure if that's done at the moment. >> >> Regards, >> >> Hans >> >> > I can mention for all these controls range as > [V4L2_CID_MPEG_VIDEO_HEVC_MIN_QP, V4L2_CID_MPEG_VIDEO_HEVC_MAX_QP]. > Will this be ok?
Yes, that sounds good.
Hans
| |