lkml.org 
[lkml]   [2018]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH] staging: rtlwifi: remove redundant initialization of 'cfg_cmd'
Date
On Fri, 2018-01-26 at 13:52 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>

> The initialization of cfg_cmd is redundant as the value is never read
> and it is being re-assigned to cfg_cmd = pwrcfgcmd[ary_idx] inside a
> loop, hence it can be removed.

> Cleans up clang warning:
> drivers/staging/rtlwifi/core.c:1819:22: warning: Value stored to
> 'cfg_cmd' during its initialization is never read

> Signed-off-by: Colin Ian King <colin.king@canonical.com>

It looks good to me.

Acked-by: Ping-Ke Shih <pkshih@realtek.com>

> ---
>  drivers/staging/rtlwifi/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/drivers/staging/rtlwifi/core.c b/drivers/staging/rtlwifi/core.c
> index a43d37452e8b..3ec039498208 100644
> --- a/drivers/staging/rtlwifi/core.c
> +++ b/drivers/staging/rtlwifi/core.c
> @@ -1816,7 +1816,7 @@ bool rtl_hal_pwrseqcmdparsing(struct rtl_priv *rtlpriv,
> u8 cut_version,
>         u8 faversion, u8 interface_type,
>         struct wlan_pwr_cfg pwrcfgcmd[])
>  {
> - struct wlan_pwr_cfg cfg_cmd = {0};
> + struct wlan_pwr_cfg cfg_cmd;
>   bool polling_bit = false;
>   u32 ary_idx = 0;
>   u8 value = 0;
> -- 
> 2.15.1


> ------Please consider the environment before printing this e-mail.
\
 
 \ /
  Last update: 2018-01-29 05:28    [W:0.043 / U:0.120 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site