lkml.org 
[lkml]   [2018]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 13/19] drm/sun4i: backend: Set a default zpos in our reset hook
On Mon, Jan 22, 2018 at 6:35 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> The our plane state zpos value will be set only if there's an existing

^^^ extra word

Otherwise,

Acked-by: Chen-Yu Tsai <wens@csie.org>

> state attached to the plane when creating the property.
>
> However, this is not the case during the probe, and we therefore need to
> put our default value in our reset hook.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
> drivers/gpu/drm/sun4i/sun4i_layer.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/sun4i/sun4i_layer.c b/drivers/gpu/drm/sun4i/sun4i_layer.c
> index c448cb6b9fa9..03549646528a 100644
> --- a/drivers/gpu/drm/sun4i/sun4i_layer.c
> +++ b/drivers/gpu/drm/sun4i/sun4i_layer.c
> @@ -28,6 +28,7 @@ struct sun4i_plane_desc {
>
> static void sun4i_backend_layer_reset(struct drm_plane *plane)
> {
> + struct sun4i_layer *layer = plane_to_sun4i_layer(plane);
> struct sun4i_layer_state *state;
>
> if (plane->state) {
> @@ -43,6 +44,7 @@ static void sun4i_backend_layer_reset(struct drm_plane *plane)
> if (state) {
> plane->state = &state->state;
> plane->state->plane = plane;
> + plane->state->zpos = layer->id;
> }
> }
>
> --
> git-series 0.9.1

\
 
 \ /
  Last update: 2018-01-29 02:54    [W:0.110 / U:10.652 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site