lkml.org 
[lkml]   [2018]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.14 028/100] IB/hfi1: Initialize bth1 in 16B rc ack builder
    Date
    From: Dennis Dalessandro <dennis.dalessandro@intel.com>

    [ Upstream commit 8935780b9f7bbad0f2eb5dd43f61ba7b509a1575 ]

    It is possible the bth1 variable could be used uninitialized so going
    ahead and giving it a default value.

    Otherwise we leak stack memory to the network.

    Fixes: 5b6cabb0db77 ("IB/hfi1: Add 16B RC/UC support")
    Reviewed-by: Don Hiatt <don.hiatt@intel.com>
    Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/infiniband/hw/hfi1/rc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/infiniband/hw/hfi1/rc.c b/drivers/infiniband/hw/hfi1/rc.c
    index e1cf0c08ca6f..84c6a6ff4a67 100644
    --- a/drivers/infiniband/hw/hfi1/rc.c
    +++ b/drivers/infiniband/hw/hfi1/rc.c
    @@ -815,7 +815,7 @@ static inline void hfi1_make_rc_ack_16B(struct rvt_qp *qp,
    struct hfi1_pportdata *ppd = ppd_from_ibp(ibp);
    struct hfi1_16b_header *hdr = &opa_hdr->opah;
    struct ib_other_headers *ohdr;
    - u32 bth0, bth1;
    + u32 bth0, bth1 = 0;
    u16 len, pkey;
    u8 becn = !!is_fecn;
    u8 l4 = OPA_16B_L4_IB_LOCAL;
    --
    2.11.0
    \
     
     \ /
      Last update: 2018-01-29 00:14    [W:4.265 / U:0.400 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site