lkml.org 
[lkml]   [2018]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.9 32/49] dmaengine: ioat: Fix error handling path
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit 5c9afbda911ce20b3f2181d1e440a0222e1027dd ]

    If the last test in 'ioat_dma_self_test()' fails, we must release all
    the allocated resources and not just part of them.

    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Acked-by: Dave Jiang <dave.jiang@intel.com>
    Signed-off-by: Vinod Koul <vinod.koul@intel.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/dma/ioat/init.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c
    index 0dea6d55f0ff..84eb83eb2efe 100644
    --- a/drivers/dma/ioat/init.c
    +++ b/drivers/dma/ioat/init.c
    @@ -388,7 +388,7 @@ static int ioat_dma_self_test(struct ioatdma_device *ioat_dma)
    if (memcmp(src, dest, IOAT_TEST_SIZE)) {
    dev_err(dev, "Self-test copy failed compare, disabling\n");
    err = -ENODEV;
    - goto free_resources;
    + goto unmap_dma;
    }

    unmap_dma:
    --
    2.11.0
    \
     
     \ /
      Last update: 2018-01-28 23:51    [W:4.245 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site