lkml.org 
[lkml]   [2018]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 3.18 12/25] net_sched: red: Avoid devision by zero
    Date
    From: Nogah Frankel <nogahf@mellanox.com>

    [ Upstream commit 5c472203421ab4f928aa1ae9e1dbcfdd80324148 ]

    Do not allow delta value to be zero since it is used as a divisor.

    Fixes: 8af2a218de38 ("sch_red: Adaptative RED AQM")
    Signed-off-by: Nogah Frankel <nogahf@mellanox.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    include/net/red.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/include/net/red.h b/include/net/red.h
    index 76e0b5f922c6..ba5039418a93 100644
    --- a/include/net/red.h
    +++ b/include/net/red.h
    @@ -178,7 +178,7 @@ static inline void red_set_parms(struct red_parms *p,
    p->qth_max = qth_max << Wlog;
    p->Wlog = Wlog;
    p->Plog = Plog;
    - if (delta < 0)
    + if (delta <= 0)
    delta = 1;
    p->qth_delta = delta;
    if (!max_P) {
    --
    2.11.0
    \
     
     \ /
      Last update: 2018-01-28 23:35    [W:2.198 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site