Messages in this thread | | | Date | Sat, 27 Jan 2018 12:13:18 +0900 | From | Stafford Horne <> | Subject | Re: [PATCH v2 3/4] openrisc: Use the new MULTI_IRQ_HANDLER |
| |
On Wed, Jan 24, 2018 at 11:46:19PM -0800, Christoph Hellwig wrote: > On Wed, Jan 24, 2018 at 07:07:55PM -0800, Palmer Dabbelt wrote: > > It appears that openrisc copied arm64's MULTI_IRQ_HANDLER code (which > > came from arm). I wanted to make this generic so I could use it in the > > RISC-V port. This patch converts the openrisc code to use the generic > > version. > > Note that openriscv overrides previous handle_arch_irq assignments. > We'll need to know from the openrisc folks if that was intentional. > > Otherwise this looks fine to me.
This looks fine to me too. We only assign the handle_arch_irq one time. I think not protecting against overrides was an oversight in the original implementation.
Acked-by: Stafford Horne <shorne@gmail.com>
-Stafford
| |