Messages in this thread | | | Date | Sat, 27 Jan 2018 01:00:45 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH 1/5] iommu/amd - Add debugfs support |
| |
On Fri, Jan 26, 2018 at 05:52:15PM -0600, Gary R Hook wrote: > Create the basic debugfs functions. Expose a count of IOMMU device > table entries that appear to be in use. > > Signed-off-by: Gary R Hook <gary.hook@amd.com> > --- > drivers/iommu/Kconfig | 9 +++ > drivers/iommu/Makefile | 2 - > drivers/iommu/amd_iommu_debugfs.c | 112 +++++++++++++++++++++++++++++++++++++ > drivers/iommu/amd_iommu_init.c | 7 ++ > drivers/iommu/amd_iommu_proto.h | 6 ++ > drivers/iommu/amd_iommu_types.h | 3 + > 6 files changed, 136 insertions(+), 3 deletions(-) > create mode 100644 drivers/iommu/amd_iommu_debugfs.c > > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig > index f3a21343e636..7753989b6be7 100644 > --- a/drivers/iommu/Kconfig > +++ b/drivers/iommu/Kconfig > @@ -135,6 +135,15 @@ config AMD_IOMMU_V2 > hardware. Select this option if you want to use devices that support > the PCI PRI and PASID interface. > > +config AMD_IOMMU_DEBUG > + bool "Expose AMD IOMMU internals in DebugFS" > + depends on AMD_IOMMU && DEBUG_FS > + default n > + help > + With this option you can enable access to AMD IOMMU registers and > + data structures through debugfs. Select this to see information > + about the internal state of the device. > + > # Intel IOMMU support > config DMAR_TABLE > bool > diff --git a/drivers/iommu/Makefile b/drivers/iommu/Makefile > index 1fb695854809..d9e9ed5f6cfc 100644 > --- a/drivers/iommu/Makefile > +++ b/drivers/iommu/Makefile > @@ -9,7 +9,7 @@ obj-$(CONFIG_IOMMU_IO_PGTABLE_LPAE) += io-pgtable-arm.o > obj-$(CONFIG_IOMMU_IOVA) += iova.o > obj-$(CONFIG_OF_IOMMU) += of_iommu.o > obj-$(CONFIG_MSM_IOMMU) += msm_iommu.o > -obj-$(CONFIG_AMD_IOMMU) += amd_iommu.o amd_iommu_init.o > +obj-$(CONFIG_AMD_IOMMU) += amd_iommu.o amd_iommu_init.o amd_iommu_debugfs.o
That looks like it needs to be:
obj-$(CONFIG_AMD_IOMMU_DEBUG) += amd_iommu_debugfs.o
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |