Messages in this thread Patch in this message | | | Subject | [PATCH 1/2] Input: omap4-keypad: Delete two error messages for a failed memory allocation in omap4_keypad_probe() | From | SF Markus Elfring <> | Date | Fri, 26 Jan 2018 14:49:07 +0100 |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Fri, 26 Jan 2018 14:24:35 +0100
Omit extra messages for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/input/keyboard/omap4-keypad.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c index 940d38b08e6b..6fe554e4026e 100644 --- a/drivers/input/keyboard/omap4-keypad.c +++ b/drivers/input/keyboard/omap4-keypad.c @@ -257,10 +257,8 @@ static int omap4_keypad_probe(struct platform_device *pdev) } keypad_data = kzalloc(sizeof(struct omap4_keypad), GFP_KERNEL); - if (!keypad_data) { - dev_err(&pdev->dev, "keypad_data memory allocation failed\n"); + if (!keypad_data) return -ENOMEM; - } keypad_data->irq = irq; @@ -340,7 +338,6 @@ static int omap4_keypad_probe(struct platform_device *pdev) keypad_data->keymap = kzalloc(max_keys * sizeof(keypad_data->keymap[0]), GFP_KERNEL); if (!keypad_data->keymap) { - dev_err(&pdev->dev, "Not enough memory for keymap\n"); error = -ENOMEM; goto err_free_input; } -- 2.16.1
| |