| Subject | Re: [PATCH 05/24] x86: Annotate indirect jump in head_64.S | From | David Woodhouse <> | Date | Fri, 26 Jan 2018 10:24:57 +0000 |
| |
On Tue, 2018-01-23 at 16:25 +0100, Peter Zijlstra wrote: > The objtool retpoline validation found this indirect jump. Seeing how > its on CPU bringup before we run userspace it should be safe, annotate
http://angryflower.com/itsits.gif
> it. > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: David Woodhouse <dwmw@amazon.co.uk>
> --- > arch/x86/kernel/head_64.S | 2 ++ > 1 file changed, 2 insertions(+) > > --- a/arch/x86/kernel/head_64.S > +++ b/arch/x86/kernel/head_64.S > @@ -23,6 +23,7 @@ > #include > #include "../entry/calling.h" > #include > +#include > > #ifdef CONFIG_PARAVIRT > #include > @@ -134,6 +135,7 @@ ENTRY(secondary_startup_64) > > /* Ensure I am executing from virtual addresses */ > movq $1f, %rax > + ANNOTATE_RETPOLINE_SAFE > jmp *%rax > 1: > UNWIND_HINT_EMPTY > > [unhandled content-type:application/x-pkcs7-signature] |