lkml.org 
[lkml]   [2018]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH net-next 0/3 V1] rtnetlink: enable IFLA_IF_NETNSID for RTM_{DEL,SET}LINK
On Wed, Jan 24, 2018 at 03:26:31PM +0100, Christian Brauner wrote:
> Hi,
>
> Based on the previous discussion this enables passing a IFLA_IF_NETNSID
> property along with RTM_SETLINK and RTM_DELLINK requests. The patch for
> RTM_NEWLINK will be sent out in a separate patch since there are more
> corner-cases to think about.
>
> Best,
> Christian
>
> Changelog 2018-01-24:
> * Preserve old behavior and report -ENODEV when either ifindex or ifname is
> provided and IFLA_GROUP is set. Spotted by Wolfgang Bumiller.
>
> Christian Brauner (3):
> rtnetlink: enable IFLA_IF_NETNSID in do_setlink()
> rtnetlink: enable IFLA_IF_NETNSID for RTM_SETLINK
> rtnetlink: enable IFLA_IF_NETNSID for RTM_DELLINK
>
> net/core/rtnetlink.c | 96 ++++++++++++++++++++++++++++++++++++++++------------
> 1 file changed, 75 insertions(+), 21 deletions(-)
>
> --
> 2.14.1
>

I've done more testing around enabling IFLA_IF_NETNSID for RTM_NEWLINK
as well and I think that the change is actually trivial. However, I
would like to wait before sending this patch out until we have agreed on
the patches for RTM_SETLINK and RTM_DELLINK in this series. Once we have
merged those I can just send another small commit. Or - if changes to
this patch series are required - I can just add it in a v2.

Thanks
Christian

\
 
 \ /
  Last update: 2018-01-25 13:59    [W:0.118 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site