Messages in this thread | | | Subject | Re: [PATCH v2] i2c: Allow ACPI_I2C_OPREGION if I2C is built as a module | From | Auger Eric <> | Date | Wed, 24 Jan 2018 17:56:01 +0100 |
| |
Hi,
On 24/01/18 17:10, Sinan Kaya wrote: > On 1/24/2018 11:09 AM, Hans de Goede wrote: >>>>> There must be a middle ground somewhere. >>>> >>>> One thing which comes to mind is to simply not allow building i2c as a module >>>> when ACPI is selected, something like this should work I think: >>>> >>>> config I2C >>>> tristate "I2C support" >>>> select RT_MUTEXES >>>> select IRQ_DOMAIN >>>> + # force building I2C in on ACPI systems, for opregion availability >>>> + depends on y || !ACPI >>> >>> This works for me.
Yes given all the concerns this patch raised, better make sure I2C is built-in along with ACPI. Sorry for the noise.
Thanks
Eric >> >> OK, so feel free to turn it into a proper patch and submit it >> upstream. > > OK. Let me do some build tests. >
| |