Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 24 Jan 2018 18:23:43 +0200 | Subject | Re: [PATCH v2 0/3] Add managed ioremap function for shared resources |
| |
On Wed, Jan 24, 2018 at 12:06 PM, Ladislav Michl <ladis@linux-mips.org> wrote: > Many drivers can simplified by using devm_ioremap_resource() > instead of open coding its functionality. However, as pointed > by Wei Yongjun, that function cannot be used when memory region > is already taken. See previous discussion here: > https://www.spinics.net/lists/linux-pci/msg68495.html > > To ease job of driver developers, new function for that > purpose is implemented and its usage shown on davinci > mtd driver. >
Sometimes we also need that, so, after addressing my comments FWIW
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Changes from previous version: > - moved function prototype in headers other way around (PATCH 1/3), > the rest of patches was dropped. > > Ladislav Michl (3): > devres: Move devm_ioremap_resource() out of device.h > devres: Add devm_ioremap_shared_resource() > mtd: nand: davinci: Use devm_ioremap_shared_resource() > > drivers/mtd/nand/davinci_nand.c | 24 +++++++----------------- > include/linux/device.h | 2 -- > include/linux/io.h | 7 +++++++ > lib/devres.c | 22 ++++++++++++++-------- > 4 files changed, 28 insertions(+), 27 deletions(-) > > -- > 2.15.1 >
-- With Best Regards, Andy Shevchenko
| |