lkml.org 
[lkml]   [2018]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] dmaengine: dmatest: fix container_of member in dmatest_callback
    Date
    Hi, Adam

    On Tue, 2018-01-23 at 09:32 -0500, Adam Wallis wrote:
    > On 1/22/2018 2:28 AM, Yang Shunyong wrote:
    > >
    > > The type of arg passed to dmatest_callback is struct dmatest_done.
    > > It refers to test_done in struct dmatest_thread, not done_wait.
    > >
    > > Fixes: 6f6a23a213be ("dmaengine: dmatest: move callback wait ...")
    > > Signed-off-by: Yang Shunyong <shunyong.yang@hxt-semitech.com>
    > > ---
    > >  drivers/dma/dmatest.c | 2 +-
    > >  1 file changed, 1 insertion(+), 1 deletion(-)
    > >
    > > diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
    > > index ec5f9d2bc820..906e85d6dedc 100644
    > > --- a/drivers/dma/dmatest.c
    > > +++ b/drivers/dma/dmatest.c
    > > @@ -355,7 +355,7 @@ static void dmatest_callback(void *arg)
    > >  {
    > >   struct dmatest_done *done = arg;
    > >   struct dmatest_thread *thread =
    > > - container_of(arg, struct dmatest_thread,
    > > done_wait);
    > > + container_of(arg, struct dmatest_thread,
    > > test_done);
    > >   if (!thread->done) {
    > >   done->done = true;
    > >   wake_up_all(done->wait);
    > >
    > Thanks for the catch
    >
    > Acked-by: Adam Wallis <awallis@codeaurora.org>

    Thanks!

    Shunyong

    \
     
     \ /
      Last update: 2018-01-24 02:48    [W:3.215 / U:0.920 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site