lkml.org 
[lkml]   [2018]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[patch v10 5/6] platform/mellanox: mlxreg-hotplug: Add check for negative adapter number value
Date
Verify before creation of hotplug device if the associated adapter number
is negative. It could be in case hotplug event is not associated with
hotplug device.

Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
---
v10->v9:
Fixes added by Vadim:
- add this patch to the series;
---
drivers/platform/mellanox/mlxreg-hotplug.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/drivers/platform/mellanox/mlxreg-hotplug.c b/drivers/platform/mellanox/mlxreg-hotplug.c
index f841379..b0d7587 100644
--- a/drivers/platform/mellanox/mlxreg-hotplug.c
+++ b/drivers/platform/mellanox/mlxreg-hotplug.c
@@ -96,6 +96,14 @@ struct mlxreg_hotplug_priv_data {
static int mlxreg_hotplug_device_create(struct device *dev,
struct mlxreg_core_data *data)
{
+ /*
+ * Return if adapter number is negative. Return if adapter number is
+ * negative. It could be in case hotplug event is not associated with
+ * hotplug device.
+ */
+ if (data->hpdev.nr < 0)
+ return 0;
+
data->hpdev.adapter = i2c_get_adapter(data->hpdev.nr);
if (!data->hpdev.adapter) {
dev_err(dev, "Failed to get adapter for bus %d\n",
--
2.1.4
\
 
 \ /
  Last update: 2018-01-23 19:39    [W:0.078 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site