lkml.org 
[lkml]   [2018]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/4] Staging: rtl8723bs: Change names to conform to the kernel code
On Sat, Jan 20, 2018 at 12:10:55AM +0530, Shreeya Patel wrote:
> Change names of some variables and functions to conform
> to the kernel coding style. The changes include some removal
> of CamelCase warnings and renaming the variable and field names
> that encode their type (eg the pointers seem to start with p).
>
> Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
> ---
>
> Changes in v3
> -Edit the commit message.
>
> drivers/staging/rtl8723bs/hal/sdio_ops.c | 714 +++++++++++++++----------------
> 1 file changed, 357 insertions(+), 357 deletions(-)

Please always test-build your patches so you don't get grumpy emails
from kernel maintainers saying your patch breaks the build :(

This give me the following error when applied:

ERROR: "DisableInterrupt8723BSdio" [drivers/staging/rtl8723bs/r8723bs.ko] undefined!
ERROR: "EnableInterrupt8723BSdio" [drivers/staging/rtl8723bs/r8723bs.ko] undefined!
ERROR: "InitInterrupt8723BSdio" [drivers/staging/rtl8723bs/r8723bs.ko] undefined!
ERROR: "InitSysInterrupt8723BSdio" [drivers/staging/rtl8723bs/r8723bs.ko] undefined!

Please fix up and resend.

greg k-h

\
 
 \ /
  Last update: 2018-01-23 11:46    [W:0.060 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site