lkml.org 
[lkml]   [2018]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Input: stmfts,s6sy671 - add SPDX identifier
On Tue, Jan 09, 2018 at 02:23:31PM +0900, Andi Shyti wrote:
> Hi Dmitry,
>
> On Fri, Jan 05, 2018 at 08:49:58AM -0800, Dmitry Torokhov wrote:
> > Hi Andi,
> >
> > On Fri, Jan 05, 2018 at 06:57:15PM +0900, Andi Shyti wrote:
> > > Hi Dmitry,
> > >
> > > this is a kind ping, would you also mind giving me a feedback to
> >
> > Yes, sorry. Could you please split the patch for each driver
> > individually? Also, until we have an update to the CodingStyle doc
> > mandating the C++ style comments, I'd prefer keeping the original style
> > of comments. So // for the SPDX line and /* */ for the rest.
>
> I was actually following Linus guideline [1] [2]. I also had the
> same discussion previously in another context [3].
>
> Please let me know if you still want a mixed style of comments in
> the next patch.

Eh, I guess it does not matter in the grand scheme of things; applied as
is.

Thank you.

>
> Thanks,
> Andi
>
> [1] https://marc.info/?l=linux-kernel&m=151163713125320&w=2
> ...
> └-> https://marc.info/?l=linux-kernel&m=151163867325641&w=2
> ...
> └-> https://marc.info/?l=linux-kernel&m=151163867325641&w=2
>
> [2] https://marc.info/?l=linux-kernel&m=150964359922353
> [3] https://marc.info/?l=linux-kernel&m=151312974503109&w=2

--
Dmitry

\
 
 \ /
  Last update: 2018-01-23 02:41    [W:0.044 / U:4.212 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site