lkml.org 
[lkml]   [2018]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] x86/retpoline: Remove the esp/rsp thunk
From
Date
On Mon, 2018-01-22 at 17:09 -0500, Waiman Long wrote:
> It doesn't make sense to have an indirect call thunk with esp/rsp as
> retpoline code won't work correctly with the stack pointer register.
> Removing it will help compiler writers to catch error in case such
> a thunk call is emitted incorrectly.
>
> Fixes: 76b043848fd2 ("x86/retpoline: Add initial retpoline support")
> Suggested-by: Jeff Law <law@redhat.com>
> Signed-off-by: Waiman Long <longman@redhat.com>

Acked-by: David Woodhouse <dwmw@amazon.co.uk>

I spotted that and *almost* removed it a couple of times in other
refactoring, but after abandoning those I forgot to come back and do
just this. Thanks.
[unhandled content-type:application/x-pkcs7-signature]
\
 
 \ /
  Last update: 2018-01-22 23:22    [W:0.036 / U:0.548 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site