lkml.org 
[lkml]   [2018]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [mm 4.15-rc8] Random oopses under memory pressure.
On Mon, Jan 22, 2018 at 5:26 AM, Rasmus Villemoes
<rasmus.villemoes@prevas.dk> wrote:
> On 2018-01-19 19:42, Linus Torvalds wrote:
>>
>> I actually asked (long long ago) for an optinal compiler warning for
>> "pointer subtraction with non-power-of-2 sizes". Not because of it
>> being undefined, but simply because it's expensive. The
>> divide->multiply thing doesn't always work,
>
> Huh? If (compile-time constant, positive) d=m*2^k with m odd, and x is
> known to be a multiple of d, x/d can always be computed as (x>>k)*m' ==
> (x*m')>>k, with m' being the mod 2^N multiplicative inverse of m, right?

Hmm. I have definitely seen gcc generate the difference with a divide.

But it may be less of a "can't do it with a multiply" and more of a
"not all versions of gcc have the multiplication optimization".

Linus

\
 
 \ /
  Last update: 2018-01-22 20:59    [W:0.114 / U:2.720 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site