lkml.org 
[lkml]   [2018]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] PCI/ASPM: Suppress common clock mode setting failure
From
Date
On 1/22/2018 12:28 PM, Sinan Kaya wrote:
> +++ b/drivers/pci/pcie/aspm.c
> @@ -253,6 +253,11 @@ static void pcie_aspm_configure_common_clock(struct pcie_link_state *link)
>
> /* Configure upstream component */
> pcie_capability_read_word(parent, PCI_EXP_LNKCTL, &reg16);
> +
> + /* Port might be already in common clock mode */
> + if ((same_clock) && (reg16 & PCI_EXP_LNKCTL_CCC))
> + return;
> +

I think the placement of this statement is too late. I'll move it a couple of lines
and post V2.

--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

\
 
 \ /
  Last update: 2018-01-22 20:14    [W:0.069 / U:0.172 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site