Messages in this thread | | | Date | Mon, 22 Jan 2018 07:55:59 -0800 | From | Tejun Heo <> | Subject | Re: [PATCH] cgroup: remove incorrect check on the return value of css_alloc |
| |
Hello,
On Mon, Jan 22, 2018 at 09:38:51PM +0800, Xiongwei Song wrote: > The function css_alloc never return NULL, it may return normal pointer or
It's a calling a controller implemented method. I'd much rather keep the extra protection.
> error codes that made by ERR_PTR, so !css is always false, we need use > IS_ERR to check it, and if this is true, we should use ERR_CAST handle it.
It's of the same type. Why would it need casting?
Thanks.
-- tejun
| |