lkml.org 
[lkml]   [2018]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 6/9] irqchip: Add the ingenic-tcu-intc driver
On Sat, 20 Jan 2018, Marc Zyngier wrote:

> On Thu, 11 Jan 2018 17:25:45 +0100
> Paul Cercueil <paul@crapouillou.net> wrote:
>
> > Hi Marc,
> >
> > >> +static int __init ingenic_tcu_intc_of_init(struct device_node
> > >> *node,
> > >> + struct device_node *parent)
> > >> +{
> > >> + struct irq_domain *domain;
> > >> + struct irq_chip_generic *gc;
> > >> + struct irq_chip_type *ct;
> > >> + int err, i, num_parent_irqs;
> > >> + unsigned int parent_irqs[3];
> > >
> > > 3 parent interrupts? Really? How do you pick one? Also, given the
> > > useage
> > > model below, "int" is the wrong type. Probably should be u32.
> >
> > See below.
> >
> > >> + struct regmap *map;
> > >> +
> > >> + num_parent_irqs = of_property_count_elems_of_size(
> > >> + node, "interrupts", 4);
> > >
> > > Nit: on a single line, as here is nothing that hurts my eyes more than
> > > reading something like(
> > > this). Also, 4 is better expressed as sizeof(u32).
> >
> > That will make checkpatch.pl unhappy :(
>
> And I don't care about checkpatch. I maintain the irqchip stuff, while
> checkpatch doesn't. Hence, I win.

num_parent_irqs =
of_property_count_elems_of_size(node, "interrupts", 4);

Everybody wins!

--
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

\
 
 \ /
  Last update: 2018-01-22 10:27    [W:0.087 / U:4.112 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site