lkml.org 
[lkml]   [2018]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 08/13] iommu/rockchip: Control clocks needed to access the IOMMU
From
Date


On 01/18/2018 10:25 PM, JeffyChen wrote:
> Hi Robin,
>
> On 01/18/2018 08:27 PM, Robin Murphy wrote:
>>>
>>
>> Is it worth using the clk_bulk_*() APIs for this? At a glance, most of
>> the code being added here appears to duplicate what those functions
>> already do (but I'm no clk API expert, for sure).
> right, i think it's doable, the clk_bulk APIs are very helpful. i think
> we didn't use that is because this patch were wrote for the chromeos 4.4
> kernel, which doesn't have clk_bulk yet:)
>
> will do it in the next version, thanks.
Also the power domain driver could manage the clocks as well, I would
suggest to use pm_runtime_*.
>>
>> Robin.
>
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>

--
Randy Li

\
 
 \ /
  Last update: 2018-01-22 02:19    [W:0.103 / U:5.156 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site