Messages in this thread | | | Date | Wed, 3 Jan 2018 09:29:18 +0530 | From | Vinod Koul <> | Subject | Re: [LINUX PATCH 3/4] dmaengine: xilinx_dma: Fix compilation warning |
| |
On Thu, Dec 21, 2017 at 03:41:37PM +0530, Kedareswara rao Appana wrote:
Fix title here too
BTW whats with LINUX tag in patches, pls drop them
> This patch fixes the below sparse warning in the driver > drivers/dma/xilinx/xilinx_dma.c: In function ‘xilinx_vdma_dma_prep_interleaved’: > drivers/dma/xilinx/xilinx_dma.c:1614:43: warning: variable ‘prev’ set but not used [-Wunused-but-set-variable] > struct xilinx_vdma_tx_segment *segment, *prev = NULL; > > Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com> > --- > drivers/dma/xilinx/xilinx_dma.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c > index 8467671..845e638 100644 > --- a/drivers/dma/xilinx/xilinx_dma.c > +++ b/drivers/dma/xilinx/xilinx_dma.c > @@ -1611,7 +1611,7 @@ xilinx_vdma_dma_prep_interleaved(struct dma_chan *dchan, > { > struct xilinx_dma_chan *chan = to_xilinx_chan(dchan); > struct xilinx_dma_tx_descriptor *desc; > - struct xilinx_vdma_tx_segment *segment, *prev = NULL; > + struct xilinx_vdma_tx_segment *segment; > struct xilinx_vdma_desc_hw *hw; > > if (!is_slave_direction(xt->dir)) > @@ -1665,8 +1665,6 @@ xilinx_vdma_dma_prep_interleaved(struct dma_chan *dchan, > /* Insert the segment into the descriptor segments list. */ > list_add_tail(&segment->node, &desc->segments); > > - prev = segment; > - > /* Link the last hardware descriptor with the first. */ > segment = list_first_entry(&desc->segments, > struct xilinx_vdma_tx_segment, node); > -- > 2.7.4 >
-- ~Vinod
| |