| From | Eric Anholt <> | Subject | Re: [PATCH v3 09/34] clk: bcm2835: change clk_get_rate() helper return type | Date | Tue, 02 Jan 2018 14:21:45 -0800 |
| |
Bryan O'Donoghue <pure.logic@nexus-software.ie> writes:
> bcm2835_pll_rate_from_divisor returns a long but the function calling it > returns an unsigned long. There's no reason to have a type disparity here > so tidy up the return type of bcm2835_pll_rate_from_divisor() from signed > to unsigned long.
I'm still surprised that clocks are using longs instead of u64s, but this seems like a fine change. For the 2 bcm2835 patches,
Reviewed-by: Eric Anholt <eric@anholt.net> [unhandled content-type:application/pgp-signature] |