lkml.org 
[lkml]   [2018]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [alsa-devel] [PATCH -next] soundwire: Fix typo in return value check of sdw_read()
From
Date
On 1/1/18 10:08 PM, Wei Yongjun wrote:
> Fix the typo, 'status' should be instead of 'status2'.

well spotted, thanks!

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

>
> Fixes: b0a9c37b0178 ("soundwire: Add slave status handling")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/soundwire/bus.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
> index 4c34519..266d2b3 100644
> --- a/drivers/soundwire/bus.c
> +++ b/drivers/soundwire/bus.c
> @@ -671,8 +671,8 @@ static int sdw_handle_dp0_interrupt(struct sdw_slave *slave, u8 *slave_status)
> status2 = sdw_read(slave, SDW_DP0_INT);
> if (status2 < 0) {
> dev_err(slave->bus->dev,
> - "SDW_DP0_INT read failed:%d", status);
> - return status;
> + "SDW_DP0_INT read failed:%d", status2);
> + return status2;
> }
> status &= status2;
>
> @@ -741,10 +741,10 @@ static int sdw_handle_port_interrupt(struct sdw_slave *slave,
>
> /* Read DPN interrupt again */
> status2 = sdw_read(slave, addr);
> - if (status < 0) {
> + if (status2 < 0) {
> dev_err(slave->bus->dev,
> - "SDW_DPN_INT read failed:%d", status);
> - return status;
> + "SDW_DPN_INT read failed:%d", status2);
> + return status2;
> }
> status &= status2;
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>

\
 
 \ /
  Last update: 2018-01-02 21:01    [W:0.034 / U:2.556 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site