lkml.org 
[lkml]   [2018]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] nokia N9: Add support for magnetometer and touchscreen
Hi,

On Tue, Jan 02, 2018 at 02:17:22PM +0100, Pavel Machek wrote:
> This adds dts support for magnetometer and touchscreen on Nokia N9.

I think it makes sense to have this splitted.

> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> diff --git a/arch/arm/boot/dts/omap3-n9.dts b/arch/arm/boot/dts/omap3-n9.dts
> index 39e35f8..57a6679 100644
> --- a/arch/arm/boot/dts/omap3-n9.dts
> +++ b/arch/arm/boot/dts/omap3-n9.dts
> @@ -36,6 +57,22 @@
> };
> };
> };
> +
> + touch@4b {

touchscreen@

> + compatible = "atmel,maxtouch";
> + reg = <0x4b>;
> + interrupt-parent = <&gpio2>;
> + interrupts = <29 2>; /* gpio_61, IRQF_TRIGGER_FALLING*/

reset-gpios = <&gpio3 17 GPIO_ACTIVE_SOMETHING>;

> + vdd-supply = <&vio>;
> + avdd-supply = <&vaux1>;

Those two are not mentioned in the binding and not supported by the
driver as far as I can see?

> + };
> +};

Touchscreen with the same settings is required for n950, so it
should be in the shared n950 + n9 file.

> +&i2c3 {
> + ak8975@0f {
> + compatible = "asahi-kasei,ak8975";
> + reg = <0x0f>;
> + };
> };

Looking at the N9 board file this is missing a rotation matrix. This
is supported by the binding:

Documentation/devicetree/bindings/iio/magnetometer/ak8975.txt

>
> &isp {

-- Sebastian
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-01-02 18:28    [W:0.026 / U:9.956 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site