| From | Mathieu Malaterre <> | Date | Tue, 2 Jan 2018 18:05:43 +0100 | Subject | Re: [PATCH v5 07/15] MIPS: Setup boot_command_line before plat_mem_setup |
| |
On Tue, Jan 2, 2018 at 4:08 PM, Paul Cercueil <paul@crapouillou.net> wrote: > From: Paul Burton <paul.burton@imgtec.com> > > Platforms using DT will typically call __dt_setup_arch from > plat_mem_setup. This in turn calls early_init_dt_scan. When > CONFIG_CMDLINE is set, this leads to its value being copied into > boot_command_line by early_init_dt_scan_chosen. If this happens before > the code setting up boot_command_line in arch_mem_init runs, that code > will go on to append CONFIG_CMDLINE (via builtin_cmdline) to > boot_command_line again, duplicating it. For some command line > parameters (eg. earlycon) this can be a problem. Set up > boot_command_line before early_init_dt_scan_chosen gets called such that > it will not write CONFIG_CMDLINE in this scenario & the arguments aren't > duplicated. > > Signed-off-by: Paul Burton <paul.burton@imgtec.com> > --- > arch/mips/kernel/setup.c | 39 ++++++++++++++++++++------------------- > 1 file changed, 20 insertions(+), 19 deletions(-) > > v2: New patch in this series > v3: No change > v4: No change > v5: No change
I would have used @mips email. Anyway:
Acked-by: Mathieu Malaterre <malat@debian.org>
|