Messages in this thread | | | From | Bart Van Assche <> | Subject | Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline | Date | Tue, 2 Jan 2018 15:11:42 +0000 |
| |
On Tue, 2018-01-02 at 15:00 +0100, Julia Lawall wrote: > On Tue, 2 Jan 2018, Bob Peterson wrote: > > ----- Original Message ----- > > > ----- Original Message ----- > > > > > Still, the GFS2 and DLM code has a plethora of broken-up printk messages, > > and I don't like the thought of re-combining them all. > > Actually, the point of the patch was to remove the unnecessary \n at the > end of the string, because log_print will add another one. If you prefer > to keep the string broken up, I can resend the patch in that form, but > without the unnecessary \n.
Please combine any user-visible strings into a single line for which the unneeded newline is dropped since these strings are modified anyway by your patch.
Thanks,
Bart. | |