Messages in this thread | | | Subject | Re: [Xen-devel] [PATCH] x86/xen/time: fix section mismatch for xen_init_time_ops() | From | Andrew Cooper <> | Date | Tue, 2 Jan 2018 14:32:17 +0000 |
| |
On 02/01/18 14:24, Juergen Gross wrote: > On 02/01/18 15:18, Boris Ostrovsky wrote: >> On 12/23/2017 09:50 PM, Nick Desaulniers wrote: >>> The header declares this function as __init but is defined in __ref >>> section. >>> >>> Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com> >> AFAIK section attributes in header files are ignored by compiler anyway >> so I'd remove all of them. > Hmm, I'm not sure all future compilers will ignore the section > attributes. include/linux/init.h explictily mentions where to put > the attrubute in a prototype, so I'd rather keep it.
Attributes in the declaration are for static analysis tools such as sparse.
How else are you going to work out whether a section mismatch has occurred?
~Andrew
| |