lkml.org 
[lkml]   [2018]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/4] ARM: amba: Make driver_override output consistent with other buses
    Date
    For AMBA devices with unconfigured driver override, the
    "driver_override" sysfs virtual file is empty, while it contains
    "(null)" for platform and PCI devices.

    Make AMBA consistent with other buses by dropping the test for a NULL
    pointer.

    Note that contrary to popular belief, sprintf() handles NULL pointers
    fine; they are printed as "(null)".

    Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
    ---
    drivers/amba/bus.c | 3 ---
    1 file changed, 3 deletions(-)

    diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c
    index 594c228d2f021123..6ffd778352e6d953 100644
    --- a/drivers/amba/bus.c
    +++ b/drivers/amba/bus.c
    @@ -70,9 +70,6 @@ static ssize_t driver_override_show(struct device *_dev,
    {
    struct amba_device *dev = to_amba_device(_dev);

    - if (!dev->driver_override)
    - return 0;
    -
    return sprintf(buf, "%s\n", dev->driver_override);
    }

    --
    2.7.4
    \
     
     \ /
      Last update: 2018-01-19 16:31    [W:2.474 / U:0.364 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site