lkml.org 
[lkml]   [2018]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 7/7] PCI: Unify wait for link active into generic pci
From
Date
On 1/19/2018 6:10 AM, Oza Pawandeep wrote:
> +++ b/drivers/pci/pcie/pcie-dpc.c
> @@ -150,37 +150,9 @@ static void dpc_wait_link_inactive(struct dpc_dev *dpc)
> struct pci_dev *pdev = dpc->dev->port;
> struct device *dev = &dpc->dev->device;
> u16 lnk_status;
> + bool active = false;
>
> - pcie_capability_read_word(pdev, PCI_EXP_LNKSTA, &lnk_status);
> - while (lnk_status & PCI_EXP_LNKSTA_DLLLA &&
> - !time_after(jiffies, timeout)) {
> - msleep(10);
> - pcie_capability_read_word(pdev, PCI_EXP_LNKSTA, &lnk_status);
> - }
> - if (lnk_status & PCI_EXP_LNKSTA_DLLLA)
> - dev_warn(dev, "Link state not disabled for DPC event\n");
> -}

I think you should reorder 6 and 7 to eliminate this.

--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

\
 
 \ /
  Last update: 2018-01-19 15:17    [W:0.091 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site