lkml.org 
[lkml]   [2018]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH-next] MEMCG: memcontrol: make local symbol static
From
Date
On Thu, 2018-01-18 at 10:08 -0500, Christopher Díaz Riveros wrote:
> Fixes the following sparse warning:
>
> mm/memcontrol.c:1097:14: warning:
> symbol 'memcg1_stats' was not declared. Should it be static?
>
> Signed-off-by: Christopher Díaz Riveros <chrisadr@gentoo.org>
> ---
> mm/memcontrol.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
[]
> @@ -1094,7 +1094,7 @@ static bool mem_cgroup_wait_acct_move(struct mem_cgroup *memcg)
> return false;
> }
>
> -unsigned int memcg1_stats[] = {
> +static unsigned int memcg1_stats[] = {

This should almost certainly be static const

> MEMCG_CACHE,
> MEMCG_RSS,
> MEMCG_RSS_HUGE,

\
 
 \ /
  Last update: 2018-01-18 20:24    [W:0.049 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site