Messages in this thread | | | Subject | Re: [PATCH v5 3/4] PCI/DPC: Unify and plumb error handling into DPC | From | Sinan Kaya <> | Date | Thu, 18 Jan 2018 13:03:45 -0500 |
| |
On 1/18/2018 1:00 PM, poza@codeaurora.org wrote: >> I think you would put into include/linux/pci.h only if there is an external >> use of constant outside of drivers/pci directory. Otherwise, you should keep >> the setting inside one of the header files in drivers/pci directory. >> >> I don't see any other subsystem caring about DPC_FATAL definition. > > ok so you are suggesting to move only DPC_FATAL ? so then AER can stay where it is.
Now that both AER and DPC handling is getting unified, I think it makes sense to keep all error codes (AER+DPC) together in drivers/pci/pci.h rather than having them split in aer.h and dpc.h.
Otherwise, how would we avoid having a new error type defined with the existing values.
-- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
| |