lkml.org 
[lkml]   [2018]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7 11/14] MIPS: ingenic: Initial JZ4770 support
Hi James,

Le mer. 17 janv. 2018 à 22:28, James Hogan <james.hogan@mips.com> a
écrit :
> On Tue, Jan 16, 2018 at 04:48:01PM +0100, Paul Cercueil wrote:
>> Provide just enough bits (clocks, clocksource, uart) to allow a
>> kernel
>> to boot on the JZ4770 SoC to a initramfs userspace.
>>
>> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>> Reviewed-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
>
>
>> diff --git a/arch/mips/jz4740/time.c b/arch/mips/jz4740/time.c
>> index bb1ad5119da4..2ca9160f642a 100644
>> --- a/arch/mips/jz4740/time.c
>> +++ b/arch/mips/jz4740/time.c
>> @@ -113,7 +113,7 @@ static struct clock_event_device
>> jz4740_clockevent = {
>> #ifdef CONFIG_MACH_JZ4740
>> .irq = JZ4740_IRQ_TCU0,
>> #endif
>> -#ifdef CONFIG_MACH_JZ4780
>> +#if defined(CONFIG_MACH_JZ4770) || defined(CONFIG_MACH_JZ4780)
>> .irq = JZ4780_IRQ_TCU2,
>> #endif
>> };
>> --
>> 2.11.0
>>
>
> MACH_INGENIC selects SYS_SUPPORTS_ZBOOT_UART16550, so I wonder whether
> arch/mips/boot/compressed/uart-16550.c needs updating for JZ4770 like
> commit ba9e72c2290f ("MIPS: Fix build with DEBUG_ZBOOT and
> MACH_JZ4780")
> does for JZ4780.
>
> Otherwise the non-DT bits look reasonable (I've not really looked
> properly at the DT):
> Reviewed-by: James Hogan <jhogan@kernel.org>
>
> Cheers
> James

I will fix it in a separate patch, if you don't mind.

-Paul

\
 
 \ /
  Last update: 2018-01-18 18:15    [W:0.082 / U:1.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site