lkml.org 
[lkml]   [2018]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] r8152: disable RX aggregation on Dell TB16 dock
From
Date


> On 18 Jan 2018, at 10:50 PM, David Miller <davem@davemloft.net> wrote:
>
> From: Hayes Wang <hayeswang@realtek.com>
> Date: Thu, 18 Jan 2018 03:04:08 +0000
>
>> [...]
>>>> r8153 on Dell TB15/16 dock corrupts rx packets.
>>>>
>>>> This change is suggested by Realtek. They guess that the XHCI
>>>> controller doesn't have enough buffer, and their guesswork is correct,
>>>> once the RX aggregation gets disabled, the issue is gone.
>>>>
>>>> ASMedia is currently working on a real sulotion for this issue.
>>>>
>>>> Dell and ODM confirm the bcdDevice and iSerialNumber is unique for TB16.
>>>>
>>>> Note that TB15 has different bcdDevice and iSerialNumber, which are
>>>> not unique values. If you still have TB15, please contact Dell to
>>>> replace it with TB16.
>>
>> Excuse me. I don't understand why this patch is for specific USB nic rather than xHCI.
>> It seems to make the specific USB nic working and the other ones keeping error.
>
> Well, are we sure that the device being in the TB16 dock doesn't
> contribute to the issue as well?

This is what vendors concluded for now. The very same NIC on WD15 doesn’t
have the issue.

>
> If the problem only shows up with XHCI and this dock, then this patch
> was the appropriate way to deal with the problem for now.

\
 
 \ /
  Last update: 2018-01-18 17:58    [W:1.072 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site