lkml.org 
[lkml]   [2018]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 16/32] tools lib traceevent: Fix missing break in FALSE case of pevent_filter_clear_trivial()
    Date
    From: Taeung Song <treeze.taeung@gmail.com>

    Currently the FILTER_TRIVIAL_FALSE case has a missing break statement,
    if the trivial type is FALSE, it will also run into the TRUE case, and
    always be skipped as the TRUE statement will continue the loop on the
    inverse condition of the FALSE statement.

    Reported-by: Namhyung Kim <namhyung@kernel.org>
    Acked-by: Namhyung Kim <namhyung@kernel.org>
    Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Link: http://lkml.kernel.org/r/20180112004823.012918807@goodmis.org
    Link: http://lkml.kernel.org/r/1493218540-12296-1-git-send-email-treeze.taeung@gmail.com
    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/lib/traceevent/parse-filter.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent/parse-filter.c
    index 2410afdcbcfe..2b9048f90bae 100644
    --- a/tools/lib/traceevent/parse-filter.c
    +++ b/tools/lib/traceevent/parse-filter.c
    @@ -1631,6 +1631,7 @@ int pevent_filter_clear_trivial(struct event_filter *filter,
    case FILTER_TRIVIAL_FALSE:
    if (filter_type->filter->boolean.value)
    continue;
    + break;
    case FILTER_TRIVIAL_TRUE:
    if (!filter_type->filter->boolean.value)
    continue;
    --
    2.14.3
    \
     
     \ /
      Last update: 2018-01-18 00:21    [W:4.865 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site