lkml.org 
[lkml]   [2018]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] firmware: qcom: scm: Fix incorrect of_node_put calls in scm_init
On Tue, Jan 16, 2018 at 08:45:49AM -0800, Bjorn Andersson wrote:
> On Fri 15 Dec 05:40 PST 2017, Loys Ollivier wrote:
>
> > When using other platform architectures, in the init of the qcom_scm
> > driver, of_node_put is called on /firmware if no qcom dt is found.
> > This results in a kernel error: Bad of_node_put() on /firmware.
> >
> > These calls to of_node_put from the qcom_scm init are unnecessary as
> > of_find_matching_node and of_platform_populate are calling it
> > automatically.
> >
> > Remove the calls to of_node_put() on fw_np.
> >
> > Fixes: d0f6fa7ba2d6 ("firmware: qcom: scm: Convert SCM to platform driver")
> > Suggested-by: Stephen Boyd <sboyd@codeaurora.org>
> > Signed-off-by: Loys Ollivier <lollivier@baylibre.com>
>
> Hi Loys,
>
> Your patch is correct! We are however removing all this logic from
> qcom_scm_init() in v4.16.
>
> See:
> https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git/commit/?h=for-next&id=3aa0582fdb824139630298880fbf78d4ac774d3c
> https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git/commit/?h=for-next&id=3aa0582fdb824139630298880fbf78d4ac774d3c


Yeah sorry for the delay in response. I pulled in the second part of a separate
fix that removes all that code from the qcom_scm. It made more sense to do it
automatically from the base code.

Andy

\
 
 \ /
  Last update: 2018-01-18 00:48    [W:0.245 / U:0.804 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site