Messages in this thread | | | Date | Mon, 15 Jan 2018 07:11:48 -0800 | From | Christoph Hellwig <> | Subject | Re: [PATCH 3/4] tsi108_eth: use dma API properly |
| |
On Wed, Jan 10, 2018 at 10:09:20PM +0200, Andy Shevchenko wrote: > > + struct platform_device *pdev; > > Do you really need platform_defice reference? > > Perhaps > > struct device *hdev; // hardware device > > > data->hdev = &pdev->dev; > > Another idea > > dev->dev.parent = &pdev->dev; > > No new member needed.
Maybe. But what I've done is the simplest change in a long obsolete driver that I don't understand at all. I'd rather keep it simple.
| |