lkml.org 
[lkml]   [2018]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/2] microblaze: fix endian handling
On Mon, Jan 15, 2018 at 11:14 AM, Michal Simek <monstr@monstr.eu> wrote:
> On 15.1.2018 10:29, Arnd Bergmann wrote:
>> On Sun, Jan 14, 2018 at 2:01 AM, kbuild test robot <lkp@intel.com> wrote:
>>> Hi Arnd,
>>>
>>> I love your patch! Yet something to improve:
>>>
>>> [auto build test ERROR on linus/master]
>>> [also build test ERROR on v4.15-rc7 next-20180112]
>>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>>>
>>> url: https://github.com/0day-ci/linux/commits/Arnd-Bergmann/microblaze-fix-endian-handling/20180105-120705
>>> config: microblaze-mmu_defconfig (attached as .config)
>>> compiler: microblaze-linux-gcc (GCC) 7.2.0
>>> reproduce:
>>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>> chmod +x ~/bin/make.cross
>>> # save the attached .config to linux build tree
>>> make.cross ARCH=microblaze
>>>
>>> All errors (new ones prefixed by >>):
>>>
>>>>> arch/microblaze/lib/fastcopy.S:33:2: error: #error Microblaze LE not support ASM optimized lib func. Disable OPT_LIB_ASM.
>>> #error Microblaze LE not support ASM optimized lib func. Disable OPT_LIB_ASM.
>>> ^~~~~
>>>
>>> vim +33 arch/microblaze/lib/fastcopy.S
>>>
>>
>> This seems to be a result of fixing one bug so we run into one that we didn't
>> get to earlier. I still assume my patch is correct.
>
> I will look at this later this week. Xilinx toolchain which I use
> normally are microblaze for BE or microblazeel that's why proper flags
> are default options already that's why I didn't see any issue.
>
> Did you take toolchain from kernel.org?
> https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.9.0/

I used a gcc-7.2.1 that I built myself for all architectures in order to debug
a gcc issue that appeared in gcc-7.2.

The patch that got tested was my workaround for an obviously broken
allmodconfig build.

Arnd

\
 
 \ /
  Last update: 2018-01-15 11:20    [W:2.165 / U:1.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site