Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH] bcma: Fix 'allmodconfig' and BCMA builds on MIPS targets | Date | Mon, 15 Jan 2018 12:03:36 +0200 |
| |
Guenter Roeck <linux@roeck-us.net> writes:
> Mips builds with BCMA host mode enabled fail in mainline and -next > with: > > In file included from include/linux/bcma/bcma.h:10:0, > from drivers/bcma/bcma_private.h:9, > from drivers/bcma/main.c:8: > include/linux/bcma/bcma_driver_pci.h:218:24: error: > field 'pci_controller' has incomplete type > > Bisect points to commit d41e6858ba58c ("MIPS: Kconfig: Set default MIPS > system type as generic") as the culprit. Analysis shows that the commmit > changes PCI configuration and enables PCI_DRIVERS_GENERIC. This in turn > disables PCI_DRIVERS_LEGACY. 'struct pci_controller' is, however, only > defined if PCI_DRIVERS_LEGACY is enabled. > > Ultimately that means that BCMA_DRIVER_PCI_HOSTMODE depends on > PCI_DRIVERS_LEGACY. Add the missing dependency. > > Fixes: d41e6858ba58c ("MIPS: Kconfig: Set default MIPS system type as ...")
So the first release for this commit was v4.15-rc1 so this is a recent regression.
> Cc: Matt Redfearn <matt.redfearn@imgtec.com> > Cc: James Hogan <jhogan@kernel.org> > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > --- > I am aware that this problem has been reported several times. I have > not been able to find a fix, but I may have missed it. If so, my > apologies for the noise.
As this fixes a build problem I'm planning to queue this for v4.15.
-- Kalle Valo
| |